Code Review Template
Template for the Code Review component of the Skills Acceptance Process.
Last updated
Was this helpful?
Template for the Code Review component of the Skills Acceptance Process.
Last updated
Was this helpful?
Was this helpful?
## Meta
* Platform:
* Mycroft-core version:
* Who: [@your-github-handle](https://github.com/your-github-handle) / @your-mycroft-chat-handle
* Datestamp: run `date +%Y-%m-%d_%H:%M:%S_%Z`
* Language and dialect of tester:
## 0. Automated tests
Are all automated tests passing?
* [ ] Skill tester - Jenkins
* [ ] Continuous Integration - Travis-CI
## 1. Code Review - secure and stable
* [ ] **Code Quality**
Can you understand what the code is doing? Is there inline documentation? Do you have any concerns about this code running on your machine? Are there any performance issues such as nested or infinite loops? Do you have significant concerns about the overall code quality?